Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump package.json + packge-lock.json #3633

Closed
wants to merge 1 commit into from

Conversation

nfranczak
Copy link
Member

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Mar 1, 2024
Copy link
Contributor

@ethanlook ethanlook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 0.10.2-next.0 after 0.11.0-rc.0?

@nfranczak
Copy link
Member Author

@ethanlook yep, I believe so

https://www.npmjs.com/package/@viamrobotics/sdk/v/0.10.2-next.0?activeTab=versions

is this a mis-nomer / should be fixed?

@nfranczak
Copy link
Member Author

I bumped them at 9:08 pm last night and I used make bump-next-version

@ethanlook
Copy link
Contributor

Hmm, interesting, I feel like this could be quite confusing. Maybe we should bump an 0.11.0 version for clarity?

@nfranczak
Copy link
Member Author

Hmm, interesting, I feel like this could be quite confusing. Maybe we should bump an 0.11.0 version for clarity?

ah ok, that sounds good to me.
I want to clarify though. When you say bump an 0.11.0 version do you mean first bump within the typescript repo and then back here in the RDK?

If I should bump within the TS repo again. I do not think make bump-next-version will work though.

Since the chronology of current versions are: 0.11.0-rc.0, 0.10.2-next.0 should next version within TS repo, if necessary, become 0.11.0-rc.1?

@ethanlook
Copy link
Contributor

When you say bump an 0.11.0 version do you mean first bump within the typescript repo and then back here in the RDK?

Correct, that's what I am thinking. @njooma which version should we bump to?

@njooma
Copy link
Member

njooma commented Mar 1, 2024

What's the timeline on this? We cut releases branches on Thursdays, and this seems to have just missed the deadline. Normally, this would have to either wait for the next release or add this in as a hotfix.

@nfranczak
Copy link
Member Author

What's the timeline on this?

no rush. What do you recommend? @njooma

@njooma
Copy link
Member

njooma commented Mar 1, 2024

I think we should just let this wait and go through the normal release process then. That would mean closing this PR

@nfranczak nfranczak closed this Mar 1, 2024
@nfranczak nfranczak deleted the bumpNPM branch March 18, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
4 participants