Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #7

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Update README.md #7

merged 3 commits into from
Dec 5, 2023

Conversation

skyleilani
Copy link
Contributor

Add "Create a repository to store the ML model to deploy" section and corrected JSON config information.

Added "Create a repository to store the ML model to deploy" section and corrected JSON config information.
Copy link
Member

@bhaney bhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one edit that I think would be important for people to consider -- it depends on the .viam directory where the cloud config file is located, which could be in /root/ for some people

Comment on lines +83 to +84
On your robot's Jetson computer, create a [structured repository](https://docs.nvidia.com/deeplearning/triton-inference-server/user-guide/docs/user_guide/model_repository.html) under the `~/.viam` directory.
The exact subpath under `~/.viam` does not matter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this today, and it didn't work unless I put it on my Orin's /root/.viam directory. I think it depends from which .viam directory the user runs from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, I added a note about the placement of the model repository. Happy to make further changes.

Copy link
Member

@bhaney bhaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skyleilani skyleilani merged commit 2254b64 into main Dec 5, 2023
2 of 3 checks passed
@skyleilani skyleilani deleted the DOCS-1396-Update-README branch December 5, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants