⚡️ perf: Bundle optimization! #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
insulineru
commented
Sep 27, 2022
webistomin
reviewed
Oct 3, 2022
iower
reviewed
Oct 3, 2022
iower
reviewed
Oct 3, 2022
insulineru
force-pushed
the
perf-optimizations
branch
from
bfcfebe
to
47acd8b
Compare
iower
approved these changes
Oct 4, 2022
nrjshka
approved these changes
Oct 4, 2022
| @@ -744,13 +749,14 @@ const WalletProvider = function WalletProvider({ children }: { children: React.R | |||
| // todo: sendTx reject => false | |||
| console.log('[Wallet] sendTx', transaction) | |||
|
|
|||
| const isSolanaTransaction = transaction instanceof Transaction | |||
| const isSolanaTransaction = 'partialSign' in transaction | |||
There was a problem hiding this comment.
Why?
instanceof requires the import of a module, but my version checks for the presence of a property, but requires only the type to import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the diff on pictures
mainbranchThis branch
Changelog:
sideEffects, use pure functions everywhere, when it's possibleENUMStoConstants. Enum from Typescript does not support tree-shaking