-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPACK sources and HTTP/2 Frame Headers #8
Conversation
The HPACK sources still need a |
Of course, sorry I got a bit caught up. Should be done, I'll commit the changes for the rest of |
I added the missing parts of I decided to include these changes too so that the To complete the module I still have to finish the unittest for |
084d8b2
to
6b68c7a
Compare
Anything still missing from your side? Otherwise I'd pull the trigger and merge. |
No, I'd say it's all here. I've almost completed a first draft for Streams, I'll submit a PR so that we can discuss that. Thanks! |
The proposed changes to
vibe-http
are the following:vibe-http/source/vibe/http/internal/http2
vibe-http/source/vibe/http/internal/http2/hpack
frame.d
module has been added, containing the implementation of astruct HTTP2FrameHeader
which can be accessed through 3 utility functions (createHTTP2FrameHeader
,serializeHTTP2FrameHeader
,unpackHTTP2FrameHeader
). This module is fullynogc
compatible and can be used to serialize / deserialize an HTTP/2 Frame Header. The next PR will contain the implementation of specific frame types (all of them are defined in RFC 7540).This, once completed, should allow for serialization and deserialization of frame headers and frame payloads, after which we could move on to stream implementation.