redis.ttl fix for expired keys. + potential implementation of redis.zrangebyscore #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns -1 for expired keys
| @@ -432,7 +432,18 @@ final class RedisClient { | |||
| return request("ZRANGE", args); | |||
| } | |||
|
|
|||
| //TODO: zrangeByScore | |||
There was a problem hiding this comment.
Potential implementation, to be discussed
|
As Jan is currently not available I'll just merge this in - it looks very reasonable to me. I'll also check with him, to avoid all those cast(ubyte[])'s and maybe also the to!string() conversions that clutter the code. |
s-ludwig
added a commit
that referenced
this pull request
Dec 1, 2012
redis.ttl fix for expired keys. + potential implementation of redis.zrangebyscore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed return type of redis.ttl from size_t(ulong) to long, since it returns -1 for expired keys
also included a potential implementation of redis.zrangebyscore covering all arguments with 2 functions.