New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis.ttl fix for expired keys. + potential implementation of redis.zrangebyscore #141

Merged
merged 2 commits into from Dec 1, 2012

Conversation

Projects
None yet
2 participants
@ekyo
Contributor

ekyo commented Nov 29, 2012

changed return type of redis.ttl from size_t(ulong) to long, since it returns -1 for expired keys

also included a potential implementation of redis.zrangebyscore covering all arguments with 2 functions.

@@ -432,7 +432,18 @@ final class RedisClient {
return request("ZRANGE", args);
}
//TODO: zrangeByScore

This comment has been minimized.

@ekyo

ekyo Nov 29, 2012

Contributor

Potential implementation, to be discussed

@ekyo

ekyo Nov 29, 2012

Contributor

Potential implementation, to be discussed

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 1, 2012

Member

As Jan is currently not available I'll just merge this in - it looks very reasonable to me. I'll also check with him, to avoid all those cast(ubyte[])'s and maybe also the to!string() conversions that clutter the code.

Member

s-ludwig commented Dec 1, 2012

As Jan is currently not available I'll just merge this in - it looks very reasonable to me. I'll also check with him, to avoid all those cast(ubyte[])'s and maybe also the to!string() conversions that clutter the code.

s-ludwig added a commit that referenced this pull request Dec 1, 2012

Merge pull request #141 from ekyo/master
redis.ttl fix for expired keys. + potential implementation of redis.zrangebyscore

@s-ludwig s-ludwig merged commit cedc978 into vibe-d:master Dec 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment