Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat invalid JSON as bad request in the rest interface #1538

Merged
merged 2 commits into from
Jul 26, 2016

Conversation

jacob-carlborg
Copy link
Contributor

The first commit strips trailing whitespace.

@s-ludwig
Copy link
Member

LGTM. Just waiting for the CI to finish.

@jacob-carlborg
Copy link
Contributor Author

I tried adding a failing test but it looked liked it was not executed. I ran dub test. Is there a way I can add a test?

@jacob-carlborg
Copy link
Contributor Author

I managed to add a test.

@s-ludwig
Copy link
Member

Okay, thanks!

@s-ludwig s-ludwig merged commit 1229d93 into vibe-d:master Jul 26, 2016
@jacob-carlborg
Copy link
Contributor Author

Thanks 😃.

@s-ludwig
Copy link
Member

Hm, just noticed this unsent message in an open tab (in case it's still useful): dub test only executes the tests of the shell "vibe-d" package. You'd need dub test :web or dub test --combined in this case.

@jacob-carlborg
Copy link
Contributor Author

jacob-carlborg commented Jul 27, 2016

Yeah, I looked in .travis.yml to figure out what to run. But the explanation on why it didn't run in the first place is useful. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants