New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat invalid JSON as bad request in the rest interface #1538

Merged
merged 2 commits into from Jul 26, 2016

Conversation

Projects
None yet
2 participants
@jacob-carlborg
Contributor

jacob-carlborg commented Jul 25, 2016

The first commit strips trailing whitespace.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 25, 2016

Member

LGTM. Just waiting for the CI to finish.

Member

s-ludwig commented Jul 25, 2016

LGTM. Just waiting for the CI to finish.

@jacob-carlborg

This comment has been minimized.

Show comment
Hide comment
@jacob-carlborg

jacob-carlborg Jul 25, 2016

Contributor

I tried adding a failing test but it looked liked it was not executed. I ran dub test. Is there a way I can add a test?

Contributor

jacob-carlborg commented Jul 25, 2016

I tried adding a failing test but it looked liked it was not executed. I ran dub test. Is there a way I can add a test?

@jacob-carlborg

This comment has been minimized.

Show comment
Hide comment
@jacob-carlborg

jacob-carlborg Jul 26, 2016

Contributor

I managed to add a test.

Contributor

jacob-carlborg commented Jul 26, 2016

I managed to add a test.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 26, 2016

Member

Okay, thanks!

Member

s-ludwig commented Jul 26, 2016

Okay, thanks!

@s-ludwig s-ludwig merged commit 1229d93 into vibe-d:master Jul 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jacob-carlborg

This comment has been minimized.

Show comment
Hide comment
@jacob-carlborg

jacob-carlborg Jul 26, 2016

Contributor

Thanks 😃.

Contributor

jacob-carlborg commented Jul 26, 2016

Thanks 😃.

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Jul 27, 2016

Member

Hm, just noticed this unsent message in an open tab (in case it's still useful): dub test only executes the tests of the shell "vibe-d" package. You'd need dub test :web or dub test --combined in this case.

Member

s-ludwig commented Jul 27, 2016

Hm, just noticed this unsent message in an open tab (in case it's still useful): dub test only executes the tests of the shell "vibe-d" package. You'd need dub test :web or dub test --combined in this case.

@jacob-carlborg

This comment has been minimized.

Show comment
Hide comment
@jacob-carlborg

jacob-carlborg Jul 27, 2016

Contributor

Yeah, I looked in .travis.yml to figure out what to run. But the explanation on why it didn't run in the first place is useful. Thanks.

Contributor

jacob-carlborg commented Jul 27, 2016

Yeah, I looked in .travis.yml to figure out what to run. But the explanation on why it didn't run in the first place is useful. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment