Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS vector in the Markdown processor #1845

Closed
s-ludwig opened this issue Jul 16, 2017 · 1 comment
Closed

XSS vector in the Markdown processor #1845

s-ludwig opened this issue Jul 16, 2017 · 1 comment
Labels
security

Comments

@s-ludwig
Copy link
Member

It's possible to inject javascript: URLs in link targets to execute arbitrary client side scripts. All parsed URLs should be restricted to a white listed set of URI schemas to avoid this.

https://www.owasp.org/index.php/XSS_Filter_Evasion_Cheat_Sheet#Image_XSS_using_the_JavaScript_directive
@s-ludwig
Copy link
Member Author

Note that there is already MarkdownSettings.urlFilter that can be used by application code to avoid this, but this still needs to be safe by default.

s-ludwig added a commit that referenced this issue Jul 16, 2017
@s-ludwig
Filter URLs in Markdown documents by a whitelist of schemas. Fixes #1845
f211035 
.
@s-ludwig s-ludwig mentioned this issue Jul 16, 2017
Merged
s-ludwig added a commit that referenced this issue Jul 16, 2017
@s-ludwig
Filter URLs in Markdown documents by a whitelist of schemas. Fixes #1845
e55b15a 
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s-ludwig