Fix WebSocket ping logic. Fixes #1471. #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
s-ludwig
commented
Jul 17, 2017
s-ludwig
commented
- Fixes server initiated PINGs to be properly masked
- Fixes the detection logic for matching PONG messages
- Uses send() to send control messages instead of manually assembling frames
- Streamlines processing of control messages
- Fixes server initiated PINGs to be properly masked - Fixes the detection logic for matching PONG messages - Uses send() to send control messages instead of manually assembling frames - Streamlines processing of control messages
s-ludwig
force-pushed
the
issue1471_websocket_ping
branch
from
6d4a86d
to
9c11b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.