Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP request reusing TCP connection leads to wrong response being processed #2507

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

ferencdg
Copy link
Contributor

@ferencdg ferencdg commented Dec 7, 2020

fixes: #2506

@Geod24
Copy link
Contributor

Geod24 commented Dec 7, 2020

Can you try to make the commit title a bit more descriptive ? "fixing major bug" isn't wrong, but it doesn't tell much to the reader, either :)
Additionally, is that something we could have a test for ?

@ferencdg ferencdg changed the title fixing major bug in TCP error handling HTTP request reusing TCP connection leads to wrong response being processed Dec 7, 2020
@ferencdg
Copy link
Contributor Author

ferencdg commented Dec 7, 2020

Can you try to make the commit title a bit more descriptive ? "fixing major bug" isn't wrong, but it doesn't tell much to the reader, either :)
Additionally, is that something we could have a test for ?

I can probably write a test code to reproduce it, but it will start up a rest server, so not sure if it is a good idea to make it a unit test.

@PetarKirov
Copy link
Contributor

Thanks for investigating and fixing this issue guys! That would surely save a lot of time for next one who bumps into this issue!

I can probably write a test code to reproduce it, but it will start up a rest server, so not sure if it is a good idea to make it a unit test.

@ferencdg in that case this folder seems like a good fit:
https://github.com/vibe-d/vibe.d/tree/master/tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP request reusing TCP connection leads to wrong response being processed
3 participants