Fixed REST client failing on POST and 201 status code. #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| Determines if status code is generally successful (>= 200 && < 300) | ||
| */ | ||
| bool isGenerallySuccessful(int status) { |
There was a problem hiding this comment.
I'd suggest to name it isSuccessCode (to match RFC naming of 2xx block) and take HTTPStatus argument as opposed to raw int.
|
Fixed and squashed. |
|
Thanks, merging in. In theory this test could be a bit too lax (e.g. when more exotic status codes, such as 207 Multi-Status are returned), but it's definitely less problematic than the current too strict solution and it's unlikely to cause any real issues practice, so it looks good after all. |
s-ludwig
added a commit
that referenced
this pull request
Sep 3, 2014
Fixed REST client failing on POST and 201 status code.
|
Thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.