New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerRestInterface and registerWebInterface should return the router #1208

Merged
merged 1 commit into from Aug 25, 2015

Conversation

Projects
None yet
2 participants
@MartinNowak
Contributor

MartinNowak commented Aug 10, 2015

So that the functions become chainable just like get/post/any and such.

MartinNowak added a commit to MartinNowak/vibe.d that referenced this pull request Aug 10, 2015

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 11, 2015

Member

Still not sure if method chaining is a good paradigm in D, considering the existence of with, but since we already have it in other places, I'd agree that it improves consistency. I'd just not want to advertise it as the standard way to access the API in the examples, maybe as a commented-out alternative right after the usual stand-alone UFCS call.

Member

s-ludwig commented Aug 11, 2015

Still not sure if method chaining is a good paradigm in D, considering the existence of with, but since we already have it in other places, I'd agree that it improves consistency. I'd just not want to advertise it as the standard way to access the API in the examples, maybe as a commented-out alternative right after the usual stand-alone UFCS call.

@MartinNowak

This comment has been minimized.

Show comment
Hide comment
@MartinNowak

MartinNowak Aug 24, 2015

Contributor

updated

Contributor

MartinNowak commented Aug 24, 2015

updated

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 25, 2015

Member

Thanks!

Member

s-ludwig commented Aug 25, 2015

Thanks!

s-ludwig added a commit that referenced this pull request Aug 25, 2015

Merge pull request #1208 from MartinNowak/fix1208
registerRestInterface and registerWebInterface should return the router

@s-ludwig s-ludwig merged commit 5d6d608 into vibe-d:master Aug 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MartinNowak MartinNowak deleted the MartinNowak:fix1208 branch Aug 26, 2015

schuetzm added a commit to schuetzm/vibe.d that referenced this pull request Aug 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment