Improve web sockets and add autobahn test suite client #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st autobahn Autobahn (http://autobahn.ws/testsuite) is a comprehensive test suite of the Websocket specifications. This test won't be run by default as it requires way too much ressources to put it into the CI, but can trivially be run manually by anyone wanting to test the websockets implementation for conformity.
We should not assume what the user is sending, as it varies from one application to another. The default might as well be binary and would seem more sensible to some.
Reduce the need for additional buffer, opening the way for more memory improvements, and document what it is doing. Also corrects a bug with length == 65536, as it would be cast to `ushort` which maximum size is 65535. Finally, fixup documentation and type of FrameOpcode.
Reduce number of static buffers (3 -> 1) Comment the internals Only demask when the frame is masked (the previous code didn't yield incorrect data, but needlessly iterated and assigned data to an array) Check that the most significant bit of the 8 bytes length is 0.
…testsuite + improvements
s-ludwig
force-pushed
the
1534_websockets
branch
from
3790b2b
to
f8bbddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #1534, adjusted for the changes in #1792.