New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept requiresAuth annotations on REST interfaces, too. #1939

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
2 participants
@s-ludwig
Member

s-ludwig commented Sep 26, 2017

Previously only classes were inspected, leading to authentication parameters being wrongly qualified as body parameters in the client generator (which just gets the interface).

Accept requiresAuth annotations on REST interfaces, too.
Previously only classes were inspected, leading to authentication parameters being wrongly qualified as body parameters in the client generator (which just gets the interface).
Allow passing the auth info type to requiresAuth for interfaces.
This avoids the need to put an actual "authenticate" method inside of the interface.

@s-ludwig s-ludwig added the auto-merge label Sep 27, 2017

@s-ludwig s-ludwig removed the auto-merge label Sep 27, 2017

@s-ludwig s-ludwig referenced this pull request Sep 27, 2017

Closed

Added test for #1922 #1924

@s-ludwig s-ludwig merged commit a7dfe6e into master Sep 27, 2017

6 checks passed

codecov/patch 50% of diff hit (target 46.088%)
Details
codecov/project 60.469% (+14.38%) compared to f5f35b6
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the rest_auth_on_interfaces branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment