Accept requiresAuth annotations on REST interfaces, too. #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only classes were inspected, leading to authentication parameters being wrongly qualified as body parameters in the client generator (which just gets the interface).
This avoids the need to put an actual "authenticate" method inside of the interface.
s-ludwig
force-pushed
the
rest_auth_on_interfaces
branch
from
460a8b2
to
8e4a8d8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only classes were inspected, leading to authentication parameters being wrongly qualified as body parameters in the client generator (which just gets the interface).