Optimize memory issues in URLRouter. Fixes #1359. #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
force-pushed
the
router_mem_opt
branch
from
b0dc813
to
79ee82b
Compare
Note that this does not fix the huge memory usage caused by the graph builder. This appears to be caused by memory fragmentation and not by the actual nominal memory usage.
Uses a combination of Array!T and a linked list for edge lists to avoid GC heap fragmentation.
s-ludwig
force-pushed
the
router_mem_opt
branch
from
79ee82b
to
e7a0f30
Compare
|
ping @s-ludwig |
s-ludwig
added a commit
that referenced
this pull request
Mar 18, 2018
s-ludwig
added a commit
that referenced
this pull request
Apr 25, 2018
s-ludwig
added a commit
that referenced
this pull request
Apr 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses manual memory management for
MatchGraphBuilderto avoid fragmenting the GC heap, which previously lead to huge process memory usage (See #1359). As a matter of fact, this also reduces the peak memory usage while building the match graph of theURLRouter.