New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize memory issues in URLRouter. Fixes #1359. #2043

Merged
merged 2 commits into from Feb 16, 2018

Conversation

Projects
None yet
3 participants
@s-ludwig
Member

s-ludwig commented Jan 24, 2018

Uses manual memory management for MatchGraphBuilder to avoid fragmenting the GC heap, which previously lead to huge process memory usage (See #1359). As a matter of fact, this also reduces the peak memory usage while building the match graph of the URLRouter.

s-ludwig added some commits Jan 22, 2018

Use small integer types for MatchGraph(Builder) to reduce memory usage.
Note that this does not fix the huge memory usage caused by the graph builder. This appears to be caused by memory fragmentation and not by the actual nominal memory usage.
Use non-GC memory for MatchGraphBuilder.
Uses a combination of Array!T and a linked list for edge lists to avoid GC heap fragmentation.
@tchaloupka

This comment has been minimized.

Contributor

tchaloupka commented Feb 6, 2018

ping @s-ludwig
probably just requires CI reset?

@s-ludwig s-ludwig added the auto-merge label Feb 16, 2018

@dlang-bot dlang-bot merged commit 6984b62 into master Feb 16, 2018

5 checks passed

codecov/patch 75.182% of diff hit (target 35.127%)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@s-ludwig s-ludwig deleted the router_mem_opt branch Feb 22, 2018

s-ludwig added a commit that referenced this pull request Mar 18, 2018

s-ludwig added a commit that referenced this pull request Apr 25, 2018

s-ludwig added a commit that referenced this pull request Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment