reimplement MongoCollection.find with projection #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
force-pushed
the
vibe-9-mongo-compat
branch
from
1507e08
to
f6dd9af
Compare
WebFreak001
force-pushed
the
vibe-9-mongo-compat
branch
from
ac32582
to
10235f6
Compare
Geod24
approved these changes
Oct 27, 2022
mongodb/vibe/db/mongo/collection.d
Outdated
| @@ -376,6 +394,33 @@ struct MongoCollection { | |||
| return MongoCursor!R(m_client, m_db.name, m_name, flags, num_skip, num_docs_per_chunk, query, returnFieldSelector); | |||
| } | |||
|
|
|||
| /** | |||
| Queries the collection for existing documents, limitting what fields are | |||
|
|
||
| See_Also: | ||
| - Querying: $(LINK http://www.mongodb.org/display/DOCS/Querying) | ||
| - Projection: $(LINK https://www.mongodb.com/docs/manual/tutorial/project-fields-from-query-results/#std-label-projections) |
mongodb/vibe/db/mongo/collection.d
Outdated
| @@ -80,7 +80,7 @@ struct MongoCollection { | |||
| Throws: Exception if a DB communication error occurred. | |||
| See_Also: $(LINK http://www.mongodb.org/display/DOCS/Updating) | |||
| */ | |||
| deprecated("Use updateOne or updateMany taking UpdateOptions instead, this method breaks in MongoDB 5.1 and onwards.") | |||
| deprecated("Use replaceOne, updateOne or updateMany taking UpdateOptions instead, this method breaks in MongoDB 5.1 and onwards.") | |||
There was a problem hiding this comment.
"Use `replaceOne`, `updateOne`, ..."
The frontend will then highlight it as it highlights keywords.
|
Thanks a lot for this, I think it'll make this module much more accessible! |
s-ludwig
requested changes
Oct 27, 2022
Also tests it + fixed examples + fixed deprecations
Was dropped with MongoDB 5.1, retrieve errors directly from the command responses (implictly done by MongoDriverException) instead
WebFreak001
force-pushed
the
vibe-9-mongo-compat
branch
from
10235f6
to
d50b7eb
Compare
|
adjusted to reviews |
WebFreak001
force-pushed
the
vibe-9-mongo-compat
branch
from
d50b7eb
to
81cb943
Compare
|
CI is red |
Before, Bson values must have been of type long for get!long to work, now Bson values of type int also work with to!long. Additionally to!double now supports long and int as well. This is useful especially for MongoDB, where return types are not strictly specified.
WebFreak001
force-pushed
the
vibe-9-mongo-compat
branch
from
81cb943
to
7803fc3
Compare
|
CI fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tests it + fixed examples + fixed deprecations
Restores backwards compatibility with older code using returnFieldMapping. I noticed the old remove/update functions are always gonna still use the old behavior. We could in theory add compatibility layers there to let users just use the old API, but I would prefer users to upgrade to the better standardized API that's common across all drivers.