refactor: improve setting function

assets/i18n.json

@@ -41,6 +41,12 @@
     "en": "mock",
     "zh": "mock"
   },
+  {
+    "category": "basic",
+    "name": "setting",
+    "en": "setting",
+    "zh": "配置"
+  },
   {
     "category": "basic",
     "name": "name",
@@ -149,6 +155,12 @@
     "en": "Please Login Your Account",
     "zh": "请登录您的账号"
   },
+  {
+    "category": "user",
+    "name": "notAllowAcess",
+    "en": "This feature does not allow the current user to use",
+    "zh": "此功能不允许当前用户使用"
+  },
   {
     "category": "user",
     "name": "account",

controllers/setting.js

@@ -8,6 +8,12 @@ const _ = require('lodash');
 
 const settingService = require('../services/setting');
 
+const validateSchema = {
+  name: Joi.string().max(30).required(),
+  data: Joi.object(),
+  disabled: Joi.boolean(),
+  description: Joi.string(),
+};
 
 /**
  * 增加一个系统配置
@@ -25,10 +31,7 @@ const settingService = require('../services/setting');
  * @return {Body} {Setting}
  */
 exports.add = async function add(ctx) {
-  const data = Joi.validate(ctx.request.body, {
-    name: Joi.string().max(30).required(),
-    data: Joi.object(),
-  });
+  const data = Joi.validate(ctx.request.body, validateSchema);
   data.creator = ctx.session.user.account;
   const doc = await settingService.add(data);
   ctx.status = 201;
@@ -89,10 +92,9 @@ exports.get = async function get(ctx) {
  */
 exports.update = async function update(ctx) {
   const id = Joi.attempt(ctx.params.id, Joi.objectId());
-  const data = Joi.validate(ctx.request.body, {
-    disabled: Joi.boolean(),
-    data: Joi.object(),
-  });
+  const data = Joi.validate(ctx.request.body, _.extend({
+    name: Joi.string().max(30),
+  }, _.omit(validateSchema, ['name'])));
   if (!_.isEmpty(data)) {
     await settingService.findByIdAndUpdate(id, data);
   }

models/setting.js

@@ -28,5 +28,6 @@ module.exports = {
     },
     // mongodb-update 的plugin会自动增加该字段
     updatedAt: String,
+    description: String,
   },
 };