Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages of libraries have to be duplicated on top level package.json #209

Open
flyingtof opened this issue May 28, 2024 · 0 comments
Open

packages of libraries have to be duplicated on top level package.json #209

flyingtof opened this issue May 28, 2024 · 0 comments

Comments

@flyingtof
Copy link
Collaborator

If we let dependency definition in (e.g.) package.json of optimizer lib, tests run by github actions fail for this lib.
The workaround is to duplicate this dependency in the top level package.json
This is due to the fact that dependencies are not installed for libs sub-folders.
@flyingtof flyingtof mentioned this issue May 28, 2024
Merged
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 28, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
eee48dd 
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 29, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
dc83727 
remove package.json,package-lock.json from optimizer
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 29, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
aa443ca 
remove package.json,package-lock.json from optimizer
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 29, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
a7d7eb2 
remove package.json,package-lock.json from optimizer
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 29, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
f46c67a 
remove package.json,package-lock.json from optimizer
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 29, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
b0f9c4b 
remove package.json,package-lock.json from optimizer
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
christophe-taret-zenika pushed a commit to flyingtof/flyxc that referenced this issue May 29, 2024
@flyingtof
fix(test): re-added igc-xc-score as a top level dependency
07787c8 
remove package.json,package-lock.json from optimizer
tests did not work with github actions because libraries are not installed
in subpackage

Issue: vicb#209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flyingtof