Use LINQ OrderBy to sort in BuildNodes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow. Epic fail. I had the correct version committed, but a) I didn't copy it to my comment correctly, and b) I didn't push the commit. 🤦🏼♂️ Thanks for the PR, but I did have the correct version already done. Take a look now? |
|
PS: If you're good with the latest code, then I'll release v3.1.0 tomorrow with the work done since 3.0.0 |
|
Ok, I did screw up. :D Thanks for fixing! |
|
Perfect! I think we can't improve this any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you find out, this is even faster than Array.Sort