-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Here's the 8chan popout code #188
Comments
How to use it with vichan? |
Simply replace vichan /js/youtube.js with my /js/youtube.js https://github.com/fatchan/vichan/blob/603228ca745188ec90ddd19d32584992fda58404/js/youtube.js |
Okay, I will replace it, what is the benefits of using this script? |
Not a bug but no, it hasn't been changed. Perhaps in mobile-style.js you could add a bit of jquery to get the src attribute of each video on the page, remove the video and add a link instead? I have almost 0 iphone traffic so I haven't bothered. |
Yes I have replaced it with your script, seems working okay, I can see youtube player and when I click it opens on iphone with no problem. Please read this thread: |
Do you know any other cool JS files which can be used with vichan? |
It does yes. If you release a file with a certain license you aren't allowed to change your mind. If they forgot to remove that header, oh well, that sucks for them but is not your problem. |
@j147 I don't know who you are or how you got push access, but you might want to merge this. |
@fatchan Have you tested this code with stock Vichan? I'm willing to merge it if so. |
Its released under MIT; the license is not a mistake. |
http://8ch.net/js/youtube.js now redirects to another webpage but you can find the script mentioned on the issue on the wayback machine: https://web.archive.org/web/20190729224551/http://8ch.net/js/youtube.js |
http://8ch.net/js/youtube.js
"Released under the MIT license" -does that count if whoever is deving 8chan right now is not making updates public? haha
Some improvements and fixes made to it, feel free to add to vichan:
https://github.com/fatchan/vichan/commit/2d7cafe78e97f4c64d5cff6b9ab35ed1d2496f3b
-Fixed size so video no longer hangs off bottom and is in the same place when the image is clicked
-It's already using font-awesome for the drag icon, so now the popout and unpop buttons use it
-Properly matching current theme
The text was updated successfully, but these errors were encountered: