Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Here's the 8chan popout code #188

Closed
fatchan opened this issue Jun 27, 2016 · 11 comments
Closed

Here's the 8chan popout code #188

fatchan opened this issue Jun 27, 2016 · 11 comments

Comments

@fatchan
Copy link

fatchan commented Jun 27, 2016

http://8ch.net/js/youtube.js
"Released under the MIT license" -does that count if whoever is deving 8chan right now is not making updates public? haha

Some improvements and fixes made to it, feel free to add to vichan:
https://github.com/fatchan/vichan/commit/2d7cafe78e97f4c64d5cff6b9ab35ed1d2496f3b
-Fixed size so video no longer hangs off bottom and is in the same place when the image is clicked
-It's already using font-awesome for the drag icon, so now the popout and unpop buttons use it
-Properly matching current theme

@sambuev
Copy link

sambuev commented Jul 1, 2016

How to use it with vichan?

@fatchan
Copy link
Author

fatchan commented Jul 2, 2016

Simply replace vichan /js/youtube.js with my /js/youtube.js https://github.com/fatchan/vichan/blob/603228ca745188ec90ddd19d32584992fda58404/js/youtube.js

@sambuev
Copy link

sambuev commented Jul 2, 2016

Okay, I will replace it, what is the benefits of using this script?
Right now current vichan doesn't play videos on mobile devices, it uses flash-ebmded style and noone can play video from iOS devices. Did you fix this bug in your script?

@fatchan
Copy link
Author

fatchan commented Jul 3, 2016

Not a bug but no, it hasn't been changed. Perhaps in mobile-style.js you could add a bit of jquery to get the src attribute of each video on the page, remove the video and add a link instead? I have almost 0 iphone traffic so I haven't bothered.

@sambuev
Copy link

sambuev commented Jul 3, 2016

Yes I have replaced it with your script, seems working okay, I can see youtube player and when I click it opens on iphone with no problem.
It's good, but VIMEO links still not playing on iOS devices.

Please read this thread:
#189

@sambuev
Copy link

sambuev commented Sep 7, 2017

Do you know any other cool JS files which can be used with vichan?

@ctrlcctrlv
Copy link
Member

"Released under the MIT license" -does that count if whoever is deving 8chan right now is not making updates public? haha

It does yes. If you release a file with a certain license you aren't allowed to change your mind. If they forgot to remove that header, oh well, that sucks for them but is not your problem.

@ctrlcctrlv
Copy link
Member

ctrlcctrlv commented Oct 18, 2017

@j147 I don't know who you are or how you got push access, but you might want to merge this.

@ctrlcctrlv
Copy link
Member

@fatchan Have you tested this code with stock Vichan? I'm willing to merge it if so.

@Cipherwraith
Copy link

If they forgot to remove that header, oh well, that sucks for them but is not your problem.

Its released under MIT; the license is not a mistake.

@PVNFU-28
Copy link

PVNFU-28 commented Feb 14, 2021

http://8ch.net/js/youtube.js now redirects to another webpage but you can find the script mentioned on the issue on the wayback machine: https://web.archive.org/web/20190729224551/http://8ch.net/js/youtube.js
edit: the wayback machine seems to have autmatically modified each link in the file, took the time to revert these changes and upload the code here: https://privatebin.net/?80a06e1579ba457a#4uZ2KUNY8AjEJ3pv85zEdqwZrK1huVo3YdJw7qvuNH1U

ctrlcctrlv added a commit that referenced this issue Mar 23, 2023
Close #543.
Close #544.
Close #543.
Close #417.
Close #384.
Close #351.
Close #350.
Close #345.
Close #327.
Close #188.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants