Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Reports of Different Posts Causing Report Queue to Show Only Same Post Reported Twice(or more) #567

Closed
tunayuyar opened this issue Apr 26, 2023 · 12 comments

Comments

@tunayuyar
Copy link

As in the subject, lets say someone reported post # 500 and another person reported # 550

Report queue shows only # 500 reported 2 times, when dismissed, shows the # 550 report.

@basedgentoo
Copy link

Can I get the output of git show to see what you're running on?
Helps for testing.

@tunayuyar
Copy link
Author

fatal: detected dubious ownership in repository at '/tahta'
To add an exception for this directory, call:

    git config --global --add safe.directory /tahta

@perdedora
Copy link
Member

perdedora commented May 7, 2023

When you dismissed the post, which button did you use?

@tunayuyar
Copy link
Author

Dismiss button not the mass dismiss one.

@tunayuyar
Copy link
Author

tunayuyar commented May 10, 2023

To provide further info on this see below screenshots, although this does not happen all the time, it happens.

I saved last report in the report queue and waited for some other reports to come, there was 3 report waiting in the queue. 1 was different remaining 2 was in the screenshot, when I dismissed 1 one of the same, the earlier different report appeared(last screenshot) and second one of the same one disappared(second one in the first screenshot).

image

image

@perdedora
Copy link
Member

They were reported by the same IP address?

@tunayuyar
Copy link
Author

No, not at all.

@RealAngeleno
Copy link

RealAngeleno commented Jul 26, 2023

Honestly probably the number 1 bug that needs to be fixed currently. Have been looking into it (on php 8.2) and have not found why it is happening. I attempted a revert of the mod functions and templates, but to no luck.

@RealAngeleno
Copy link

RealAngeleno commented Jul 28, 2023

Added a print_r($reports); to debug and reports get fetched from the database just fine, but don't display properly still. That removes some possibility of it being from mod_reports(). I have no idea where the error lies. I'll continue debugging.

@RealAngeleno
Copy link

I stand corrected. Used a mod_reports function from 2019 and it works just fine.

@RealAngeleno
Copy link

RealAngeleno commented Jul 28, 2023

Changing
foreach ($reports as &$report) {
to
foreach ($reports as $report) {
fixes it.
on line 2291 in inc/mod/pages.php

RealAngeleno added a commit that referenced this issue Jul 28, 2023
RealAngeleno added a commit that referenced this issue Jul 28, 2023
@RealAngeleno
Copy link

It's been fixed via #610.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants