-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[widgets.mpd] Add fields ${Artists}
and ${Genres}
#117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patchset looks good to me, aside from some minor formatting issues. After you're done resolving them, could you please test if both Artists
and Genres
are working?
${Artists}
and ${Generes}
${Artists}
and ${Genres}
Genres was broken before because of the typo, but now It's working fine: The update function: local update = function (widget, args)
if args["{state}"] == "Stop" then
widget.visible = false
return ''
else
widget.visible = true
return {
('Artists: %s Track: %s Genres: %s'):format(args["{Artists}"], args["{Title}"], args["{Genres}"]),
args["{state}"]
}
end
end And what mpd is returning:
More than one artist it's working as expected too:
Here I couldn't find any tracks that have multiples of other tags, not being genre, artist or albumArtist. So just concatenating Artist and Genre it's fine IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will merge and tag a new release this weekend.
Resolves GH-116
Adds new return values to widgets.mpd that concatenate all artists and generes when there's more than one. For tracks with vorbis metadata.
I've also updated the docs to reflect those changes.