Skip to content

Commit

Permalink
fix typo (#584)
Browse files Browse the repository at this point in the history
  • Loading branch information
@daixtrose
daixtrose committed May 23, 2024
1 parent c94e871 commit 1a6ca5c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/rpp/rpp/observables/blocking_observable.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace rpp::details::observables
{
class blocking_disposble final : public base_disposable
class blocking_disposable final : public base_disposable
{
public:
void wait()
Expand Down Expand Up @@ -63,7 +63,7 @@ namespace rpp::details::observables
template<rpp::constraint::observer_strategy<Type> ObserverStrategy>
void subscribe(observer<Type, ObserverStrategy>&& obs) const
{
auto d = disposable_wrapper_impl<blocking_disposble>::make();
auto d = disposable_wrapper_impl<blocking_disposable>::make();
obs.set_upstream(d);
m_original.subscribe(std::move(obs));

Expand Down

1 comment on commit 1a6ca5c

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BENCHMARK RESULTS (AUTOGENERATED)

ci-ubuntu-gcc

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 304.17 ns 2.21 ns 2.16 ns 1.02
Subscribe empty callbacks to empty observable via pipe operator 311.44 ns 2.16 ns 2.16 ns 1.00

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 694.98 ns 0.31 ns 0.31 ns 1.00
from array of 1 - create + subscribe + current_thread 1048.78 ns 3.42 ns 3.42 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2220.33 ns 115.00 ns 116.98 ns 0.98
defer from array of 1 - defer + create + subscribe + immediate 729.58 ns 0.31 ns 0.31 ns 1.02
interval - interval + take(3) + subscribe + immediate 2131.62 ns 59.29 ns 59.19 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3026.81 ns 32.42 ns 32.40 ns 1.00
from array of 1 - create + as_blocking + subscribe + new_thread 29927.12 ns 28262.35 ns 27908.68 ns 1.01
from array of 1000 - create + as_blocking + subscribe + new_thread 37569.14 ns 52814.22 ns 50740.48 ns 1.04

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1105.47 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 871.67 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 987.44 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 838.07 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1278.95 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+last()+subscribe 935.59 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1142.27 ns 17.60 ns 17.59 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 300.04 ns 2.16 ns 2.16 ns 1.00
current_thread scheduler create worker + schedule 369.93 ns 5.87 ns 5.87 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 833.88 ns 55.00 ns 55.85 ns 0.98

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 883.01 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 908.75 ns 0.31 ns 0.31 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2324.35 ns 169.77 ns 164.18 ns 1.03
immediate_just+buffer(2)+subscribe 1609.83 ns 13.89 ns 13.89 ns 1.00
immediate_just+window(2)+subscribe + subscsribe inner 2382.73 ns 1078.86 ns 1078.03 ns 1.00

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 824.23 ns - - 0.00
immediate_just+take_while(true)+subscribe 840.08 ns 0.31 ns 0.31 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 1957.77 ns 0.31 ns 0.31 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3421.24 ns 188.14 ns 190.69 ns 0.99
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3687.76 ns 172.79 ns 178.31 ns 0.97
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 142.26 ns 129.93 ns 1.09
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3582.20 ns 968.48 ns 1016.01 ns 0.95
immediate_just(1) + zip(immediate_just(2)) + subscribe 2088.11 ns 203.56 ns 219.48 ns 0.93

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 34.57 ns 16.86 ns 16.85 ns 1.00

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1339.40 ns 13.90 ns 13.90 ns 1.00
basic sample with immediate scheduler 1363.77 ns 5.55 ns 5.55 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 907.88 ns 0.31 ns 0.31 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 1074.17 ns 131.35 ns 130.71 ns 1.00

ci-macos

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 977.97 ns 3.86 ns 5.53 ns 0.70
Subscribe empty callbacks to empty observable via pipe operator 975.92 ns 3.85 ns 5.53 ns 0.70

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1944.32 ns 0.23 ns 0.34 ns 0.70
from array of 1 - create + subscribe + current_thread 2582.95 ns 34.03 ns 46.84 ns 0.73
concat_as_source of just(1 immediate) create + subscribe 5419.41 ns 336.68 ns 487.80 ns 0.69
defer from array of 1 - defer + create + subscribe + immediate 1979.93 ns 0.23 ns 0.36 ns 0.64
interval - interval + take(3) + subscribe + immediate 4949.90 ns 115.69 ns 191.88 ns 0.60
interval - interval + take(3) + subscribe + current_thread 6005.92 ns 95.72 ns 143.49 ns 0.67
from array of 1 - create + as_blocking + subscribe + new_thread 87270.21 ns 83226.15 ns 145507.12 ns 0.57
from array of 1000 - create + as_blocking + subscribe + new_thread 91052.58 ns 90706.64 ns 128129.38 ns 0.71

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 2869.58 ns 0.23 ns 0.34 ns 0.69
immediate_just+filter(true)+subscribe 2131.37 ns 0.23 ns 0.34 ns 0.70
immediate_just(1,2)+skip(1)+subscribe 2860.93 ns 0.23 ns 0.34 ns 0.70
immediate_just(1,1,2)+distinct_until_changed()+subscribe 2087.23 ns 0.47 ns 0.67 ns 0.70
immediate_just(1,2)+first()+subscribe 3195.79 ns 0.23 ns 0.34 ns 0.69
immediate_just(1,2)+last()+subscribe 2396.22 ns 0.23 ns 0.34 ns 0.70
immediate_just+take_last(1)+subscribe 3036.41 ns 70.36 ns 101.13 ns 0.70

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 864.59 ns 4.03 ns 6.67 ns 0.60
current_thread scheduler create worker + schedule 1195.14 ns 38.68 ns 67.27 ns 0.58
current_thread scheduler create worker + schedule + recursive schedule 2010.44 ns 206.34 ns 769.62 ns 0.27

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 2123.21 ns 0.23 ns 0.34 ns 0.69
immediate_just+scan(10, std::plus)+subscribe 2363.88 ns 0.47 ns 0.67 ns 0.70
immediate_just+flat_map(immediate_just(v*2))+subscribe 5458.05 ns 402.78 ns 580.65 ns 0.69
immediate_just+buffer(2)+subscribe 2486.74 ns 72.85 ns 98.73 ns 0.74
immediate_just+window(2)+subscribe + subscsribe inner 5401.86 ns 2293.46 ns 3306.06 ns 0.69

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 2178.37 ns - - 0.00
immediate_just+take_while(true)+subscribe 2199.54 ns 0.25 ns 0.34 ns 0.73

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 4963.62 ns 0.23 ns 0.34 ns 0.70

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 7424.51 ns 440.14 ns 2320.98 ns 0.19
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 8439.56 ns 442.90 ns 884.77 ns 0.50
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 461.60 ns 666.61 ns 0.69
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 8035.24 ns 1910.58 ns 2755.53 ns 0.69
immediate_just(1) + zip(immediate_just(2)) + subscribe 5280.38 ns 868.54 ns 1202.63 ns 0.72

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 76.56 ns 49.34 ns 70.95 ns 0.70

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 2899.00 ns 73.08 ns 144.65 ns 0.51
basic sample with immediate scheduler 2810.37 ns 15.40 ns 27.06 ns 0.57

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 2381.09 ns 0.24 ns 0.34 ns 0.70

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 6576.58 ns 4108.33 ns 5973.13 ns 0.69

ci-ubuntu-clang

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 270.78 ns 1.54 ns 1.56 ns 0.99
Subscribe empty callbacks to empty observable via pipe operator 268.36 ns 1.54 ns 1.56 ns 0.99

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 560.63 ns 0.31 ns 0.31 ns 1.00
from array of 1 - create + subscribe + current_thread 797.88 ns 4.01 ns 4.02 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2336.35 ns 134.50 ns 141.37 ns 0.95
defer from array of 1 - defer + create + subscribe + immediate 776.49 ns 0.31 ns 0.31 ns 1.00
interval - interval + take(3) + subscribe + immediate 2203.42 ns 58.26 ns 58.30 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3162.08 ns 31.17 ns 31.17 ns 1.00
from array of 1 - create + as_blocking + subscribe + new_thread 30156.94 ns 27416.00 ns 28093.97 ns 0.98
from array of 1000 - create + as_blocking + subscribe + new_thread 38286.41 ns 34862.26 ns 34260.24 ns 1.02

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1149.39 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 843.67 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 1107.85 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 887.57 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1368.05 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+last()+subscribe 1007.16 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1203.87 ns 0.31 ns 0.31 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 287.25 ns 1.54 ns 1.57 ns 0.98
current_thread scheduler create worker + schedule 402.09 ns 4.01 ns 4.02 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 847.35 ns 55.59 ns 57.81 ns 0.96

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 840.04 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 978.84 ns 0.62 ns 0.62 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2230.12 ns 138.90 ns 138.42 ns 1.00
immediate_just+buffer(2)+subscribe 1546.76 ns 14.21 ns 14.19 ns 1.00
immediate_just+window(2)+subscribe + subscsribe inner 2471.35 ns 874.98 ns 894.31 ns 0.98

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 837.26 ns - - 0.00
immediate_just+take_while(true)+subscribe 845.44 ns 0.31 ns 0.31 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 1982.63 ns 0.31 ns 0.31 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3235.76 ns 160.85 ns 160.54 ns 1.00
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3750.17 ns 148.39 ns 148.33 ns 1.00
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 142.14 ns 142.23 ns 1.00
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3399.51 ns 840.50 ns 838.80 ns 1.00
immediate_just(1) + zip(immediate_just(2)) + subscribe 2264.46 ns 203.35 ns 201.90 ns 1.01

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 52.24 ns 18.53 ns 18.53 ns 1.00

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1303.20 ns 11.11 ns 11.11 ns 1.00
basic sample with immediate scheduler 1297.18 ns 6.17 ns 6.17 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 1016.25 ns 0.31 ns 0.31 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 1066.48 ns 134.79 ns 134.34 ns 1.00

ci-windows

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 564.38 ns 4.75 ns 4.73 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 587.35 ns 4.71 ns 4.77 ns 0.99

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1154.51 ns 5.24 ns 5.24 ns 1.00
from array of 1 - create + subscribe + current_thread 1421.10 ns 15.74 ns 15.74 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 3760.22 ns 182.97 ns 194.38 ns 0.94
defer from array of 1 - defer + create + subscribe + immediate 1190.62 ns 5.55 ns 5.55 ns 1.00
interval - interval + take(3) + subscribe + immediate 3088.04 ns 133.58 ns 133.64 ns 1.00
interval - interval + take(3) + subscribe + current_thread 4111.58 ns 51.55 ns 53.90 ns 0.96
from array of 1 - create + as_blocking + subscribe + new_thread 128722.22 ns 123700.00 ns 113380.00 ns 1.09
from array of 1000 - create + as_blocking + subscribe + new_thread 139042.86 ns 138914.29 ns 136011.11 ns 1.02

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1814.29 ns 12.87 ns 12.87 ns 1.00
immediate_just+filter(true)+subscribe 1310.22 ns 11.64 ns 11.65 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 2244.89 ns 13.06 ns 13.09 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 1360.82 ns 15.83 ns 15.83 ns 1.00
immediate_just(1,2)+first()+subscribe 2057.89 ns 12.95 ns 12.95 ns 1.00
immediate_just(1,2)+last()+subscribe 1454.87 ns 14.05 ns 14.04 ns 1.00
immediate_just+take_last(1)+subscribe 2036.92 ns 59.29 ns 59.29 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 488.83 ns 6.17 ns 6.17 ns 1.00
current_thread scheduler create worker + schedule 662.25 ns 13.20 ns 13.08 ns 1.01
current_thread scheduler create worker + schedule + recursive schedule 1089.58 ns 105.50 ns 105.55 ns 1.00

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 1318.99 ns 11.86 ns 11.71 ns 1.01
immediate_just+scan(10, std::plus)+subscribe 1447.06 ns 21.58 ns 21.59 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 3547.97 ns 224.03 ns 222.85 ns 1.01
immediate_just+buffer(2)+subscribe 2310.75 ns 58.31 ns 57.79 ns 1.01
immediate_just+window(2)+subscribe + subscsribe inner 4042.57 ns 1252.19 ns 1705.07 ns 0.73

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 1311.13 ns 11.41 ns 11.41 ns 1.00
immediate_just+take_while(true)+subscribe 1314.96 ns 11.65 ns 11.63 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 3570.07 ns 7.71 ns 7.71 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 5971.58 ns 234.81 ns 230.69 ns 1.02
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 5789.94 ns 232.16 ns 225.50 ns 1.03
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 227.49 ns 243.22 ns 0.94
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 5480.61 ns 962.29 ns 961.92 ns 1.00
immediate_just(1) + zip(immediate_just(2)) + subscribe 3668.91 ns 527.24 ns 554.41 ns 0.95

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 36.31 ns 27.44 ns 27.44 ns 1.00

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1850.73 ns 56.82 ns 56.86 ns 1.00
basic sample with immediate scheduler 2164.40 ns 37.95 ns 37.97 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 1462.04 ns 19.97 ns 20.03 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 1929.31 ns 336.92 ns 349.83 ns 0.96

Please sign in to comment.