Change logic of disposables

[victimsnino]

No description provided.

[codecov]

Codecov Report

Merging #338 (436001e) into v2 (4c1f9a0) will decrease coverage by 1.05%.
The diff coverage is 89.43%.

@@            Coverage Diff             @@
##               v2     #338      +/-   ##
==========================================
- Coverage   89.89%   88.85%   -1.05%     
==========================================
  Files          16       18       +2     
  Lines         287      314      +27     
  Branches       58       56       -2     
==========================================
+ Hits          258      279      +21     
+ Misses          8        7       -1     
- Partials       21       28       +7     

Impacted Files	Coverage Δ
src/rpp/rpp/utils/functors.hpp	50.00% <ø> (ø)
src/rpp/rpp/observables/base_observable.hpp	88.88% <66.66%> (-3.42%)	⬇️
src/rpp/rpp/disposables/base_disposable.hpp	73.07% <73.07%> (ø)
src/rpp/rpp/disposables/disposable_wrapper.hpp	84.61% <84.61%> (ø)
src/rpp/rpp/operators/details/strategy.hpp	96.66% <88.88%> (+1.79%)	⬆️
src/rpp/rpp/observers/base_observer.hpp	88.88% <94.91%> (-2.03%)	⬇️
src/rpp/rpp/observers/dynamic_observer.hpp	100.00% <100.00%> (ø)
src/rpp/rpp/observers/fwd.hpp	100.00% <100.00%> (ø)
src/rpp/rpp/observers/lambda_observer.hpp	100.00% <100.00%> (+16.66%)	⬆️
src/rpp/rpp/operators/map.hpp	62.50% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

BENCHMARK RESULTS (AUTOGENERATED)

ci-ubuntu-gcc

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	707.81 ns	0.69 ns	1.67 ns	0.41
Subscribe empty callbacks to empty observable via pipe operator	709.19 ns	0.67 ns	1.68 ns	0.40

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	2708.25 ns	0.67 ns	0.33 ns	2.00

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
take(1)	1451.65 ns	0.33 ns	13.03 ns	0.03

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	709.25 ns	1.00 ns	1.34 ns	0.75

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
create+map(v*2)+subscribe	856.50 ns	0.33 ns	11.09 ns	0.03

ci-macos

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	1137.43 ns	0.57 ns	0.84 ns	0.68
Subscribe empty callbacks to empty observable via pipe operator	1141.06 ns	0.57 ns	0.84 ns	0.69

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	3080.61 ns	0.45 ns	0.42 ns	1.07

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
take(1)	2116.78 ns	0.28 ns	5.33 ns	0.05

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	1012.51 ns	2.56 ns	2.79 ns	0.92

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
create+map(v*2)+subscribe	1202.85 ns	0.29 ns	0.27 ns	1.04

ci-ubuntu-clang

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	335.46 ns	0.60 ns	0.67 ns	0.89
Subscribe empty callbacks to empty observable via pipe operator	335.43 ns	0.60 ns	0.67 ns	0.90

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	1040.33 ns	0.42 ns	0.37 ns	1.12

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
take(1)	644.64 ns	0.40 ns	0.33 ns	1.20

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	248.45 ns	0.80 ns	1.34 ns	0.60

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
create+map(v*2)+subscribe	367.80 ns	0.40 ns	0.33 ns	1.20

ci-windows

General

name	rxcpp	rpp	prev rpp	ratio
Subscribe empty callbacks to empty observable	1171.59 ns	1.67 ns	1.67 ns	1.00
Subscribe empty callbacks to empty observable via pipe operator	1182.14 ns	1.67 ns	1.67 ns	1.00

Sources

name	rxcpp	rpp	prev rpp	ratio
from array of 1 - create + subscribe + immediate	3387.57 ns	8.69 ns	9.36 ns	0.93

Filtering Operators

name	rxcpp	rpp	prev rpp	ratio
take(1)	3038.76 ns	7.85 ns	14.30 ns	0.55

Schedulers

name	rxcpp	rpp	prev rpp	ratio
immediate scheduler create worker + schedule	1142.59 ns	3.68 ns	3.34 ns	1.10

Transforming Operators

name	rxcpp	rpp	prev rpp	ratio
create+map(v*2)+subscribe	1332.18 ns	5.85 ns	14.73 ns	0.40

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

92.3% Coverage
0.0% Duplication