Skip to content

Commit

Permalink
urls
Browse files Browse the repository at this point in the history
  • Loading branch information
victor-navarro committed Mar 12, 2024
1 parent 1a8fa0c commit 18738f9
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 30 deletions.
21 changes: 7 additions & 14 deletions R/assertions.R
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
return("RW1972")
} else {
if (!(given %in% supported_models())) {
stop("Model is not supported. Must be one returned by
supported_models()")
stop("Model is not supported. Must be one returned by supported_models()")
}
return(given)
}
Expand Down Expand Up @@ -36,8 +35,7 @@
return("optim")
} else {
if (!given %in% supported_optimizers()) {
stop("Optimizer is not supported. Must be one
returned by supported_optimizers()")
stop("Optimizer is not supported. Must be one returned by supported_optimizers()")
} else {
return(given)
}
Expand All @@ -49,17 +47,15 @@
return("identity")
} else {
if (!(given %in% supported_families())) {
stop("Family is not supported. Must be one
returned by supported_families()")
stop("Family is not supported. Must be one returned by supported_families()")
} else {
return(given)
}
}
},
"limits_OK" = {
if (any(is.na(given$ll)) | any(is.na(given$ul))) {
stop("Did not supply limits for all parameters estimated.
Count your parameters. Please see ?fit_model")
stop("Did not supply limits for all parameters estimated. Count your parameters. Please see ?fit_model")
}
},
"filepath_OK" = {
Expand All @@ -72,20 +68,17 @@
length(given$unique_nominal_stimuli) >
length(given$unique_functional_stimuli)
) {
stop("The model does not support functional/nominal
stimuli specifications.")
stop("The model does not support functional/nominal stimuli specifications.")
}
},
"supported_plot" = {
if (!(given %in% nargs$supported)) {
stop(sprintf("Plot not supported. The model does
not contain '%s' in model results.", given))
stop(sprintf("Plot not supported. The model does not contain '%s' in model results.", given))
}
},
"good_experiment" = {
if (length(given@design@mapping$unique_nominal_stimuli) == 1) {
stop("Experiment is too simple to run for one or more groups.
Please check your design.")
stop("Experiment is too simple to run for one or more groups. Please check your design.")
}
},
"length" = {
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Canonical Associative Learning Models and their Representations

<!-- badges: start -->
[![R-CMD-check](https://github.com/victor-navarro/calmr/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/victor-navarro/calmr/actions/workflows/R-CMD-check.yaml)
[![codecov](https://codecov.io/gh/victor-navarro/calmr/graph/badge.svg?token=8VTS3MQX51)](https://codecov.io/gh/victor-navarro/calmr)
[![codecov](https://app.codecov.io/gh/victor-navarro/calmr/graph/badge.svg?token=8VTS3MQX51)](https://app.codecov.io/gh/victor-navarro/calmr)
<!-- badges: end -->

## Installing the latest stable version
Expand All @@ -24,7 +24,7 @@ install.packages("devtools")
devtools::install_github("victor-navarro/calmr")
```

If you managed to build the vignettes, there's a vignette showing the basics of the package. (Worry not, the package's [website](https://www.victornavarro.org/calmr) also has it).
If you managed to build the vignettes, there's a vignette showing the basics of the package. (Worry not, the package's [website](https://victornavarro.org/calmr/) also has it).

```
vignette("calmr_basics", package = "calmr")
Expand Down
14 changes: 1 addition & 13 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,6 @@
## Comments

### Third submission

>Thanks, we see:
Found the following (possibly) invalid file URI:
URI: www.victornavarro.org/calmr
From: README.md
Pls specify the URL completely and start with the protocol, e.g. https://...
Please fix and resubmit.

Fixed to include the protocol. Apologies for the inconvenience.


### Second submission (calmr 0.6.0 -> 0.6.1)
### Resubmission (calmr 0.6.0 -> 0.6.1)

Thank you very much for the feedback and my apologies for the oversights. See my comments below.

Expand Down
2 changes: 2 additions & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ ABAB
ALC
ANCCR
Bugfix
CMD
CalmrDesign
CalmrExperiment
CalmrFit
Expand Down Expand Up @@ -42,6 +43,7 @@ asymptote
attentional
behaviour
cardiff
codecov
colour
comparator
containign
Expand Down
2 changes: 1 addition & 1 deletion vignettes/calmr_fits.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ we simply address this issue by running several iterations of the experiment
(with random trial orders) and averaging all experiments before evaluating the
likelihood of the parameters.

So what do we have to design? The experiment presented by Patittuci
So what do we have to design? The experiment presented by Patitucci
et al. (2016) was fairly simple, and it can be reduced to the
presentations of two levers, each followed by a different appetitive
outcome. Here, we will assume that the two outcomes are independent
Expand Down

0 comments on commit 18738f9

Please sign in to comment.