-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to build on case-sensitive sytems and use the minified js file #77
Conversation
+1 |
+1 i need that! @victorbjelkholm could you please merge this one and release? @pauljohncleary i think you could keep the non minified file For those who wants a quick fix to your CI, replace the bower version by:
|
@thiagofesta I'm curious- any particular reason to keep the non minified available in the build? |
@pauljohncleary my idea was to keep as the author did, and also, usually people minify their code, so keeping the non minified means that on the dev time you are dealing with the full version of the file, which helps out in case there is some error related to, you can test easier. What are your thoughts? |
Hey guys, sorry for not updating you earlier. Been very busy lately... But this seems important, I'll merge this today. |
Thanks @victorbjelkholm :) |
Hi @victorbjelkholm, thanks for your work and sorry to bother you... but can you please merge this? Thanks in advance! |
+1 |
I think the PR has been pending for long time. |
I don't see any problem with this PR... @victorbjelkholm said he was going to merge it, but I don't know what happened. |
+1 |
I am not sure why @victorbjelkholm does not approve it. It's all good. He should approve that or add someone to manage his repository (if there is no time to verify, and release new versions), to approve and help the opensource community. He won't spend more than 5 minutes to release a new version... For now use one of these solutions: #77 (comment), #77 (comment) |
@victorbjelkholm I see the last commit was August 2 2015. It will be nice if you delegate it to other contributors if you are too busy. |
+1 in the hopes of this getting in soon! |
+1 |
Fix to build on case-sensitive sytems and use the minified js file
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "ngprogress", | |||
"version": "1.1.2", | |||
"version": "1.1.3", | |||
"description": "slim, site-wide progressbar for AngularJS", | |||
"main": "ngProgress.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr fixed the bower.json
, but not package.json
. With bower being replaced by npm for a lot of devs this is an issue with module resolution.
On case-sensitive operating system (e.g. whatever CircleCI uses) files must be specified in their correct case, this changes that so bower can find the js file. Also switched to the min file.