Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix promise detection #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix promise detection #30

wants to merge 1 commit into from

Conversation

chocolateboy
Copy link

Functions are objects and are valid thenables:

"promise" is an object or function with a then method
whose behavior conforms to this specification. [1]

This PR uses is-promise to detect promises in a spec-compliant way.

[1] https://promisesaplus.com/#terminology

functions are objects and are valid thenables:

    "promise" is an object or function with a then method
    whose behavior conforms to this specification. [1]

use is-promise to detect promises rather than reimplementing
it buggily.

[1] https://promisesaplus.com/#terminology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant