Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG_Icons on navbar not appearing when using other language beyond English #63

Closed
carvalholeo opened this issue Dec 27, 2022 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@carvalholeo
Copy link
Contributor

Describe the bug
All icons (except the pencil and transactions) don't appear when you use a different language in the system. So, the interface could be broken for non-English iDevices users.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings' app on the system. So, enter into 'General' section. After, 'Language & Region'
  2. On 'Preferred Languages,' tap to 'Add Language' and select one of the supported languages at the app (e.g, 'Portuguese (Brazil)' or French). So, put as preferred language.
  3. Allow to iPhone restart device with new language
  4. Open Abacus to see navbar without almost any icons
  5. Repeat steps 1-4, changing language back to English, to see all icons back.

Expected behavior
As a non-English user of the app, I expect that icons must appear, to guide me and myself experience across the app on how to use.

Screenshots
Navigation bar when using in Portuguese
IMG_4005

Navigation bar when using in English
IMG_4006

Smartphone:

  • Device: iPhone12
  • OS: iOS 16.1.2
  • Version 0.4.0

Additional context
Probably this bug it was generated by me. It occurs because on routes screen, the object for icons expect receive for a name in English. While the app didn't translate, this wasn't a problem.

But, when I made the last PR (#48), I introduced this bug for translating navigation bar names, that were used to access object with icons names. Sorry for this.

I'm working right now at a bugfix for this. I'm sorry for neither report nor see this bug before, I don't have an Apple setup (any Mac, it's too much expensive in Brazil) to debug iOS apps.

Likewise, I believe that between today and Friday, I'm going to open a new PR, solving this bug.

@carvalholeo carvalholeo added the bug Something isn't working label Dec 27, 2022
@victorbalssa
Copy link
Owner

will be fixed in next update.

@victorbalssa victorbalssa added this to the 0.5.0 milestone Jan 5, 2023
@victorbalssa
Copy link
Owner

@carvalholeo should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants