Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New translations keys #48

Merged

Conversation

carvalholeo
Copy link
Contributor


name: Pull request
about: Translations
title: FEATURE_
labels: enhancement
assignees: victorbalssa


Is your feature request related to a problem? Please describe.
This PR is an update of #42, adding new keys to translation and implementing those into the app.

Describe the solution you'd like
Create new keys for en-US translation and implement these across the app, using translate function, create before.

Describe alternatives you've considered
Use fixed texts in English.

Additional context
At previous PR, I don't see some fixed texts on screen. So, they weren't translated and the internationalization it was incomplete.

@carvalholeo
Copy link
Contributor Author

Hey @gariasf and @umarhadi , maybe you want to see this and add more translations.

@victorbalssa victorbalssa merged commit dd6b289 into victorbalssa:updates Nov 8, 2022
@umarhadi
Copy link
Contributor

umarhadi commented Nov 12, 2022

Hey @gariasf and @umarhadi , maybe you want to see this and add more translations.

working on it..


done #54

@gariasf
Copy link
Contributor

gariasf commented Nov 12, 2022

Also updated them in #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants