Improved separation of style and content/state/layout, and various other #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2023 16:48
- removed id, checked, enabled, hint, text, textOff, textOn, visibility, x, y, w, h from props - removed documentation of style methods - PViewMethodsInterface: added method id() - PUI.getViewById: changed argument type from String to int - PViewsArea: removed method addView(PViewMethodsInterface) - added methods text(), textOn(String), textOn(), textOff(String), textOff(), checked() - changed text(String) to return this - changed textFont to preserve text style - changed textStyle to preserve text font - removed empty specializations of Styler - removed unused instance variables
victordiaz
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
Hi @notEvil I just reviewed and tested the changes. Everything is good from my point of view.
Thanks so much for the cleanup you did here :) 🎉
This was referenced Mar 12, 2023
victordiaz
added a commit
that referenced
this pull request
Mar 24, 2023
Partial revert of #141 and improved properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #139