Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nuxt components not being typed #70

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: nuxt components not being typed #70

merged 1 commit into from
Feb 14, 2023

Conversation

mahdiboomeri
Copy link
Contributor

@mahdiboomeri mahdiboomeri commented Feb 14, 2023

First of all, thank you for this module. It's really well thought out and a pleasant experience!
This PR addresses an issue with Volar. If you use both vue and @vue/runtime-core, Nuxt components lose their type.
For more context, please see Danielroe's comments on this PR formkit/formkit#581

@vercel
Copy link

vercel bot commented Feb 14, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @victorgarciaesgi on Vercel.

@victorgarciaesgi first needs to authorize it.

@victorgarciaesgi
Copy link
Owner

Hi! Thanks a lot for this PR, will publish it right away

@victorgarciaesgi victorgarciaesgi merged commit 9f7c7a0 into victorgarciaesgi:master Feb 14, 2023
@mahdiboomeri mahdiboomeri deleted the fix/nuxt-component-types branch February 14, 2023 20:56
victorgarciaesgi added a commit that referenced this pull request Feb 23, 2023
fix: GlobalComponents declaration #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants