Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for iedit-hide-unmatched-lines #30

Merged
merged 3 commits into from Jan 19, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 18 additions & 12 deletions iedit-lib.el
Expand Up @@ -521,14 +521,18 @@ value of `iedit-occurrence-context-lines' is used for this time."
(save-excursion
(iedit-first-occurrence)
(while (/= (point) (point-max))
(forward-line (- context-lines))
(let ((line-beginning (line-beginning-position)))
(if (> line-beginning prev-occurrence-end)
(push (list prev-occurrence-end (1- line-beginning)) unmatched-lines)))
(let ((current-start (point)))
(forward-line (- context-lines))
(let ((line-beginning (line-beginning-position)))
(if (> line-beginning prev-occurrence-end)
(push (list prev-occurrence-end (1- line-beginning)) unmatched-lines)))
(goto-char current-start))
;; goto the end of the occurrence
(goto-char (next-single-char-property-change (point) 'iedit-occurrence-overlay-name))
(forward-line context-lines)
(setq prev-occurrence-end (line-end-position))
(let ((current-end (point)))
(forward-line context-lines)
(setq prev-occurrence-end (1+ (line-end-position)))
(goto-char current-end))
;; goto the beginning of next occurrence
(goto-char (next-single-char-property-change (point) 'iedit-occurrence-overlay-name)))
(if (< prev-occurrence-end (point-max))
Expand Down Expand Up @@ -765,12 +769,14 @@ This function is supposed to be called in overlay keymap."
(defun iedit-current-occurrence-string ()
"Return current occurrence string.
Return nil if occurrence string is empty string."
(let* ((ov (or (iedit-find-current-occurrence-overlay)
(car iedit-occurrences-overlays)))
(beg (overlay-start ov))
(end (overlay-end ov)))
(if (and ov (/= beg end))
(buffer-substring-no-properties beg end)
(let ((ov (or (iedit-find-current-occurrence-overlay)
(car iedit-occurrences-overlays))))
(if ov
(let ((beg (overlay-start ov))
(end (overlay-end ov)))
(if (and ov (/= beg end))
(buffer-substring-no-properties beg end)
nil))
nil)))

(defun iedit-occurrence-string-length ()
Expand Down
21 changes: 12 additions & 9 deletions iedit.el
Expand Up @@ -356,15 +356,18 @@ Keymap used within overlays:
(if (or isearch-regexp isearch-word)
nil
(setq iedit-initial-string-local isearch-string))
(isearch-exit)
(setq mark-active nil)
(run-hooks 'deactivate-mark-hook)
(iedit-start regexp (point-min) (point-max))
;; TODO: reconsider how to avoid the loop in iedit-same-length
(if (iedit-same-length)
nil
(iedit-done)
(message "Matches are not the same length.")))
(let ((iedit-case-sensitive (not isearch-case-fold-search)))
(isearch-exit)
(setq mark-active nil)
(run-hooks 'deactivate-mark-hook)
(iedit-start regexp (point-min) (point-max))
;; TODO: reconsider how to avoid the loop in iedit-same-length
(cond ((not iedit-occurrences-overlays)
(message "No matches found")
(iedit-done))
((not (iedit-same-length))
(message "Matches are not the same length.")
(iedit-done)))))

(defun iedit-start (occurrence-regexp beg end)
"Start Iedit mode for the `occurrence-regexp' in the current buffer."
Expand Down