Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Assets and CORS errors in theme's demos #135

Closed
onedrawingperday opened this issue Mar 13, 2019 · 2 comments
Closed

Missing Assets and CORS errors in theme's demos #135

onedrawingperday opened this issue Mar 13, 2019 · 2 comments
Assignees

Comments

@onedrawingperday
Copy link

onedrawingperday commented Mar 13, 2019

Hello again,

As you may remember, I am one of the maintainers of Hugo Themes and it has come to my attention that since PR #126 was merged this theme's demos both on the Hugo Themes website and on Netlify are throwing CORS errors.

The CSS stylesheets are not loading because the credentials flag was set to 'same-origin' in the above PR. see https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_settings_attributes for more info.

Also note

My advice would be to either revert the CORS changes from #126 or amend the CORS policy to allow for the external assets that this theme requires or move every external asset in this repository.

Please do look into this and let me know once you issue a fix.

Thank you.

cc: @hanzei @victoriadotdev @digitalcraftsman

@victoriadrake
Copy link
Owner

victoriadrake commented Mar 18, 2019

@onedrawingperday CORS policy has been amended plus some relative link tweaks. Netlify seems to work now, please let me know if the theme demo issue persists.

@onedrawingperday
Copy link
Author

@victoriadotdev I will let you know in a separate issue, once I test your theme with the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants