Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS and Polish lang #126

Merged
merged 4 commits into from Jan 25, 2019
Merged

CORS and Polish lang #126

merged 4 commits into from Jan 25, 2019

Conversation

chew-z
Copy link
Contributor

@chew-z chew-z commented Jan 19, 2019

Hi,

I propose adding crossorigin=anonymous for signed stylesheets to allow for CORS policy.

Practical example - I keep my web page in S3 bucket and redirect both naked domain and www domain into the same bucket (this is rare scenario - most people duplicate buckets).

So I had to enable CORS like in this article However CORS cannot be used without crossorigin=anonymous set. (explained here

Also added pl.toml for Polish language.

@hanzei hanzei self-requested a review January 25, 2019 14:26
@hanzei hanzei self-assigned this Jan 25, 2019
@hanzei hanzei added this to the v4.1.0 milestone Jan 25, 2019
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hanzei hanzei merged commit 9b49548 into victoriadrake:master Jan 25, 2019
@hanzei
Copy link
Collaborator

hanzei commented Jan 25, 2019

Thanks for the PR @chew-z! 👍

victoriadrake added a commit that referenced this pull request Mar 13, 2019
er-vin pushed a commit to er-vin/hugo-theme-introduction that referenced this pull request Mar 14, 2019
I propose adding `crossorigin=anonymous`  for signed stylesheets to allow for CORS policy. 

Practical example - I keep my web page in S3 bucket and redirect both naked domain and www domain into the same bucket (this is rare scenario - most people duplicate buckets). 

So I had to enable CORS like in [this article](https://medium.com/@Keithweaver_/only-allowing-access-to-your-s3-bucket-via-your-website-5ca5c8546152) However CORS cannot be used without crossorigin=anonymous set. (explained [here](https://stackoverflow.com/questions/32039568/what-are-the-integrity-and-crossorigin-attributes)

Also added pl.toml for Polish language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants