Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hero sizes #137

Merged
merged 2 commits into from Mar 15, 2019
Merged

Fix hero sizes #137

merged 2 commits into from Mar 15, 2019

Conversation

victoriadrake
Copy link
Owner

  • Use proper sections in index.html to comply with bulma styles
  • Update default value of header height to "fullheight" (shows navbar)

- Use proper sections in index.html to comply with bulma styles
- Update default value of header height to "fullheight" (shows navbar)
@er-vin
Copy link
Contributor

er-vin commented Mar 14, 2019

For the record I just tested this patch locally, and that fixes the long standing issue I had with the hero sizes since the big theme refactoring. Looking forward to it getting merged!

Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but I leaved to comments on the IMO unrelated changes.

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@hanzei hanzei added this to the v4.1.0 milestone Mar 15, 2019
@hanzei hanzei mentioned this pull request Mar 15, 2019
@victoriadrake victoriadrake merged commit 632bcd4 into master Mar 15, 2019
@victoriadrake victoriadrake deleted the fix-hero branch March 15, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants