Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the menu appear when introHeight is large #128

Closed
wants to merge 1 commit into from

Conversation

er-vin
Copy link
Contributor

@er-vin er-vin commented Feb 1, 2019

To that effect, introduce a new hero is-bottom-menu class which uses
viewport height at 80% to give room for the menu (can't be perfect since
we of course can't mix vh and rem units). Also make sure we use that
class instead of is-large when introHeight is set to large.

That should match the behavior discussed previously.

To that effect, introduce a new hero is-bottom-menu class which uses
viewport height at 80% to give room for the menu (can't be perfect since
we of course can't mix vh and rem units). Also make sure we use that
class instead of is-large when introHeight is set to large.

That should match the behavior discussed previously.
@hanzei
Copy link
Collaborator

hanzei commented Feb 4, 2019

Hey @er-vin,

Thanks for the PR! Would you mind sharing some before/after screenshots?

@hanzei hanzei self-requested a review February 4, 2019 13:54
@hanzei hanzei self-assigned this Feb 4, 2019
@er-vin
Copy link
Contributor Author

er-vin commented Feb 7, 2019

Yes, sure, here they are. First without the patch, full page and viewport on load:
without_patch_full
without_patch_viewport

And now with the patch, full page and viewport on load:
with_patch_full
with_patch_viewport

Now obviously the problem with my approach is that if the viewport is not tall enough, the menu might still be out. That's because I found no good way to express the menu height in term of the vh unit. Suggestions welcome but I doubt we can do it without switch the menu to the vh unit as well, which will probably do strange things on very tall viewports.

@er-vin
Copy link
Contributor Author

er-vin commented Mar 8, 2019

For the record I didn't find another way of doing it which wouldn't involve vh or doing weird things to the menu (as in switching it to vh which would have other side-effects). So expect if you got suggestions I think this patch will be definitive.

@victoriadrake
Copy link
Owner

Hey @er-vin!

Thank you for the PR. I believe your goal is better addressed with changes made in #137 which corrects the index template.

The hero height is set using Bulma's styling, and I believe the value you're after is "fullheight". This will show the navbar at the bottom of the hero regardless of the viewport height.

@er-vin
Copy link
Contributor Author

er-vin commented Mar 14, 2019

OK, I admit I'm slightly confused because your decision now contradicts what you said on my previous attempt at fixing this which was more similar to #137. It was shutdown at the time. Oh well... :-)

I'm totally fine with #137, obviously I far prefer that approach. Really looking forward to it being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants