Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add author field to blog #322

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Add author field to blog #322

merged 2 commits into from
Feb 21, 2022

Conversation

alexbeattie42
Copy link
Contributor

  • Adds the ability to have different authors for blog post entries

victoriadrake
victoriadrake requested changes Feb 13, 2022
View reviewed changes
Copy link
Owner

@victoriadrake victoriadrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Alex! Thank you for the PR!

I think it would be good to add some handling for when there is no author parameter on the post. Otherwise, we see an empty byline:
image

@alexbeattie42
Copy link
Contributor Author

Good catch. Thank you. Updated now

@victoriadrake victoriadrake merged commit c88d3a3 into victoriadrake:master Feb 21, 2022
@victoriadrake
Copy link
Owner

Thank you Alex!

@victoriadrake victoriadrake mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoriadrake victoriadrake victoriadrake requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexbeattie42 @victoriadrake