adding photoswipe to gallery page #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thank you very much Arthur, this looks to work smoothly with or without JS and the implementation is well done. Can you think of any way the user could optionally turn on or off keeping the image aspect ratio? With different image ratios, the gallery can end up looking quite choppy:
|
|
Great idea Victoria! Just committed a change that adds the option |
|
Just found a bug, give me a minute to fix. |
|
Beautiful! Thank you so much for contributing Arthur! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #88.
Note about #85: i've changed the grid to keep the images aspect ratio. This is specially important for PhotoSwipe animation works properly. Also removed the
border-bottomproperty of gallery image links.