Fix bug where process is prematurely stopped due to receiving a full array of skippedMessages #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…array of skippedMessages
AstroOrbis
approved these changes
Mar 25, 2022
victornpb
added
the
PR looks good
victornpb
added a commit
that referenced
this pull request
Apr 29, 2022
Bump Discord API version to version 9 and add more message type to be deleted PR looks good (#223 by VictorienXP) Add wildcard subdomain for discord.com match on the userscript (#224 by VictorienXP) Fix bug where process is prematurely stopped due to receiving a full array of skippedMessages (#323 by aijorgenson) fix: stricter url matching (#335 by SethFalco) refactor: reduce number of @matchs (#336 by SethFalco) Removed duplicate OR operator (#338 by aydinyal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when deleting a large message set (in my specific case over 16k messages), you may populate up to the entire page size with messages that have to be skipped due to invalid type. The message "Ended because API returned an empty page." is displayed to the console, incorrectly informing the user of what actually happened.
If you stop and restart the process, the first page will be filled with messages that have to be skipped. This causes the script to prematurely fail instead of skipping to the next page.
This may possibly also resolve the following in a one line change:
Console output before the fix:
Console output after the fix:
This change is