patch: skip archived messages after one attempt #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: Notice how the next page gets the archived messages again...
After: Next page continues off of last deletion (thanks to increment on offset)
|
|
Seems there are conflicts, let me rebase |
|
FYI: RE: 2k changed lines on the compiled script, I just ran |
|
thank you for your contribution, looks good to me. A more long term solution would be trying to filter out threads entirely, idk if thats possible tho |
victornpb
approved these changes
Jul 4, 2023
you are right, thank you |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, archived threads are a big problem: We fail to delete messages in an archived thread. This itself could be seen as a problem, but the bigger problem (IMO), is that these messages keep coming up when searching new pages, since they are still returned by the search call! This is a major problem when the number of archived messages hits 25, since a new page will return all archived messages, and no progress can be made.
This MR implements a kind of patch - if we fail to delete a message, and the reason is that the thread is archived , then we increment the offset.
This allows the fetch of the next page to skip these archived messages from the search results, allowing the overall deletion to make further progress.
Other MRs
#457 -> This hack fix doesn't help much, since the next search will yield these messages again.
#393 -> This is arguable more efficient, but has a lot of changes, so may take more time to review merge. In the meantime a patch to at least allow further progress on non-archived messages could be useful to some.