Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast high is always 72F #256

Closed
robster2001 opened this issue Dec 1, 2023 · 3 comments
Closed

Forecast high is always 72F #256

robster2001 opened this issue Dec 1, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@robster2001
Copy link

Describe the bug
During the day, when the forecast displays the forecast high temperature, it's always showing 72F instead of the correct forecast.

To Reproduce
Simply have the forecast displayed on the Bonjourr home page.

Expected behavior
It should show correct forecast high.

Screenshots
See attached. Today's forecast is for a high of 59F in my area.
Screenshot 2023-12-01 093157

Device (please complete the following information):

  • OS: Windows 11 Beta 22635.2776
  • Browser: Chrome 119.0.6045.200
@victrme
Copy link
Owner

victrme commented Dec 2, 2023

Hi @robster2001

Oops 😅 When re-writing forecast in the previous version, I left this old condition if current_forecast < new_forecast, which result in the forecast not updating when days are getting colder !

Thanks for opening this issue, it will be fixed !

@victrme victrme added the bug Something isn't working label Dec 2, 2023
@victrme victrme closed this as completed Dec 4, 2023
@Gitoffthelawn
Copy link
Contributor

And just like that, @victrme solved global warming for all humankind! 🌍 ❤️

@robster2001
Copy link
Author

I just got 1.18.4 and can confirm this is fixed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants