Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script postinstall con husky@5 #142

Closed
DUBANGARCIA opened this issue Feb 14, 2021 · 3 comments
Closed

Script postinstall con husky@5 #142

DUBANGARCIA opened this issue Feb 14, 2021 · 3 comments
Labels
bug Something isn't working released

Comments

@DUBANGARCIA
Copy link

馃悰 Bug report

Steps to reproduce

  • When upgrading to version 1.2.21 or higher, the postinstall script runs so husky tries to look for the .github folder and can't find it.

Expected behaviour

When publishing the package you should not have package.json scripts.

Actual behaviour

When I install the package the scripts in package.json are maintained

Version: 1.2.21

Captura de pantalla_2021-02-14_10-04-07
@DUBANGARCIA DUBANGARCIA added the bug Something isn't working label Feb 14, 2021
@jdbruijn
Copy link
Member

Hi @DUBANGARCIA, thanks for reporting this issue!

I've recently updated to Husky v5, but forgot to disable the postinstall script in the published package. I'll add it shortly as per their documentation.

I realise I also have this issue in my commitlint-config repository, so double thanks for pointing this out!

ghost pushed a commit that referenced this issue Feb 14, 2021
chore(release): 1.1.23 [skip ci]
1c83410 
### [1.1.23](v1.1.22...v1.1.23) (2021-02-14)

### Build System

* remove `postinstall` script from the published package ([7898ead](7898ead)), closes [#142](#142)
@ghost
Copy link

ghost commented Feb 14, 2021

馃帀 This issue has been resolved in version 1.1.23 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@ghost ghost added the released label Feb 14, 2021
@jdbruijn
Copy link
Member

@DUBANGARCIA Should be fixed now in 1.1.23. Please feel free to re-open this if you're still having issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DUBANGARCIA @jdbruijn