Skip to content

Commit

Permalink
switch to node 18, unpin netlify-cli, and workaround npm ci then …
Browse files Browse the repository at this point in the history
…being broken (#5180)

* switch to node 18

which is now LTS

* unpin `netlify-cli`

* use `npm-ci-please` to workaound `npm ci` being broken

fixes #5115

* set version using `npm version`

which will also update the version in the package-lock

* be selective about what goes in artifact

to speed things up

* use newer `npm-ci-please`

* fix setting version on netlify

* fix permission on script

* listen on all interfaces for sauce labs

because otherwise with node 18 the server is not reachable through the proxy for some reason
  • Loading branch information
tjenkinson authored and robwalch committed Jan 26, 2023
1 parent ef00bcc commit f1c5a87
Show file tree
Hide file tree
Showing 9 changed files with 21,331 additions and 6,092 deletions.
1 change: 0 additions & 1 deletion .github/workflows/automerge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ jobs:
with:
repo-token: ${{ secrets.CI_GITHUB_TOKEN }}
allowed-actors: renovate[bot]
package-block-list: netlify-cli
22 changes: 12 additions & 10 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand All @@ -94,7 +94,7 @@ jobs:
- name: set version
run: |
node ./scripts/set-package-version.js
./scripts/set-package-version.sh
env:
CI: true
TAG: ${{ needs.config.outputs.tag }}
Expand All @@ -115,10 +115,12 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: build
# version number is set in package.json so need to include that
path: |
**
!**/[.]*/**
!**/node_modules/
package.json
package-lock.json
api-docs/**
dist/**
test_unit:
needs: build
Expand Down Expand Up @@ -150,7 +152,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -191,7 +193,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -291,7 +293,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -353,7 +355,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -435,7 +437,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18

0 comments on commit f1c5a87

Please sign in to comment.