Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty metadata textTrack added regardless of in-band data #1330

Closed
4 tasks done
wallg opened this issue Sep 5, 2017 · 3 comments
Closed
4 tasks done

Empty metadata textTrack added regardless of in-band data #1330

wallg opened this issue Sep 5, 2017 · 3 comments
Labels

Comments

@wallg
Copy link

wallg commented Sep 5, 2017

Environment
Steps to reproduce
  1. Load the demo page https://video-dev.github.io/hls.js/demo/
  2. Open console, to inspect video element
    var p = document.getElementsByTagName('video')[0];
    p.textTracks[0]
  3. Observe a metadata text track.
Expected behavior

textTracks.length === 0

Actual behavior

trxtTracks 'addtrack' event is fired
textTracks.length === 1

I was unable to find reasoning for this track being added, and I believe it is being added here:

this.id3Track = this.media.addTextTrack('metadata', 'id3');

I'm not sure why, but in browsers that support native playback of hls, the 'addtrack' event is not fired and the metadata track is not added to the array of textTracks.

@wallg
Copy link
Author

wallg commented Sep 6, 2017

I have also noticed that calling Hls.destroy() does not remove this text tracks (since there is currently no way to do this in the media element spec). This seems like a good reason not to add this track to the element.

@mangui
Copy link
Member

mangui commented Sep 8, 2017

indeed this textTrack needs to be created dynamically on first id3 frame found. attached commit should address that.

@stale
Copy link

stale bot commented Jun 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Wontfix label Jun 16, 2018
@stale stale bot closed this as completed Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants