Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: JWT addon will be deprecated #1572

Closed
azu opened this issue Feb 19, 2018 · 12 comments
Closed

Travis CI: JWT addon will be deprecated #1572

azu opened this issue Feb 19, 2018 · 12 comments
Projects

Comments

@stale
Copy link

stale bot commented Jun 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Wontfix label Jun 15, 2018
@azu
Copy link
Collaborator Author

azu commented Jun 16, 2018

hls.js still use JWT addon.

@stale
Copy link

stale bot commented Aug 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Aug 15, 2018
@stale stale bot closed this as completed Aug 22, 2018
@itsjamie
Copy link
Collaborator

itsjamie commented Feb 14, 2019

This still needs to be fixed by April.

Options really seem to be:

  • knowingly expose SauceLabs API credentials in environment variables (keep current state, PR builds for everyone)
  • move SauceLabs API credentials to secure environment variables, only run SauceLab tests on repository collaborators
  • build some tooling that doesn't output information into a log that is public, but will trigger SauceLabs, and shoot the result of the test back to the GitHub Checks API.

Does anyone know of a integration someone has built for SauceLabs that does this? The JWT addon has been going away for awhile.

@itsjamie itsjamie reopened this Feb 14, 2019
@stale stale bot removed the Stale label Feb 14, 2019
@itsjamie itsjamie added this to the 0.12.3 milestone Feb 14, 2019
@itsjamie itsjamie added this to To do in Tooling via automation Feb 14, 2019
@tjenkinson
Copy link
Member

Not saying we shouldn't think about it, but the message said it was being removed last April not this April, so it's possible saucelabs changed their mind

@itsjamie itsjamie removed this from the 0.12.3 milestone Feb 14, 2019
@itsjamie
Copy link
Collaborator

Hah. The year did catch me. This is odd that it all still functions then.

Maybe we can let this go stale?

@tjenkinson
Copy link
Member

tjenkinson commented Feb 14, 2019 via email

@stale
Copy link

stale bot commented Apr 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@michaelcunningham19
Copy link
Member

I emailed them asking what their plan is

@tjenkinson Did you ever hear back?

@jonhoo
Copy link

jonhoo commented Apr 25, 2019

For what it's worth, in fantoccini I just switched to using the browsers on Travis directly: jonhoo/fantoccini@06dccdd

@tjenkinson
Copy link
Member

@michaelcunningham19 I never heard back from them

@stale
Copy link

stale bot commented Jun 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jun 24, 2019
@stale stale bot closed this as completed Jul 24, 2019
Tooling automation moved this from To do to Done Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Tooling
  
Done
Development

No branches or pull requests

5 participants