Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video tearing in feature/v1.0.0 branch #2514

Closed
robwalch opened this issue Jan 29, 2020 · 0 comments
Closed

Video tearing in feature/v1.0.0 branch #2514

robwalch opened this issue Jan 29, 2020 · 0 comments
Assignees
@robwalch @michaelcunningham19
Labels
Bug
Projects
Release Planning and Backlog
Milestone
1.0.0

Comments

@robwalch
Copy link
Collaborator

What version of Hls.js are you using?

feature/v1.0.0

What browser and OS are you using?

Chrome 79, macos 10.15.2

Test stream:

The first test stream on the demo page (Big Buck Bunny - adaptive qualities)
https://deploy-preview-2370--hls-js-pr.netlify.com/demo/

Steps to reproduce

  1. Playback the first stream on the demo test page https://deploy-preview-2370--hls-js-pr.netlify.com/demo/
  2. You may want to fix playback to the highest level or leave ABR on
  3. Play to about 17-20 seconds in

Expected behavior

Video decoding should not tear or display green blocks

Actual behavior

There's minor tearing at 10s
and major tearing at around 17s
sometimes with green chroma background (key frame not rendered)

Screen Shot 2020-01-29 at 1 55 02 PM

Notes

This is probably a recent regression in feature/v1.0.0. We should find the changeset where this started and work from there.
@robwalch robwalch added this to the 1.0.0 milestone Jan 29, 2020
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Jan 29, 2020
@robwalch robwalch added the Bug label Jan 29, 2020
robwalch pushed a commit that referenced this issue Feb 26, 2020
Remove change in tsdemuxer that caused video tearing
ba07abc 
Fixes #2514
robwalch pushed a commit to jwplayer/hls.js that referenced this issue Feb 27, 2020
Merge branch 'feature/v1.0.0' into LHLS
37a7b5e 
* feature/v1.0.0:
  Remove change in tsdemuxer that caused video tearing Fixes video-dev#2514
  fix: remove uneeded tests
  remove computeLive test
  Update base-stream-controller.js
  Fix issue in TS Demuxer that skipped AAC frames at the end of PES packets Fixes video-dev#2528
  Update dependencies and package-lock
  Fix formatting of example
  Remove stats assert since loader resets stats
  Use fragment stats in loaders and reset stats on load
  fix: computeLivePosition minimum value of media.currentTime
  trigger ci
  remove .only
  load audio playlist on MANIFEST_PARSED
  tsdemuxer: if PES does not contain PTS/DTS, use last PES PTS/DTS instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robwalch robwalch

@michaelcunningham19 michaelcunningham19

Labels
Bug
Projects
HLS.js Release Planning and Backlog
Archived in project
Release Planning and Backlog
  
Top priorities
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@robwalch @michaelcunningham19