Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest refresh logic #359

Closed
shaharmor opened this issue Apr 7, 2016 · 4 comments
Closed

Manifest refresh logic #359

shaharmor opened this issue Apr 7, 2016 · 4 comments

Comments

@shaharmor
Copy link
Contributor

Hey @mangui,

I've noticed that the refresh logic for a manifest (located here: https://github.com/dailymotion/hls.js/blob/master/src/controller/level-controller.js#L239) can be problematic in cases where the length of segments is changing drastically within the manifest.

For example, if there is a manifest with segments ranging 2s - 15s, the #EXT-X-TARGETDURATION value will be 15, but its possible there will be 3 (or more) consecutive segments with a total duration of less than 15s, causing the player to stall due to having no knowledge of new segments to load (Until the next tick).

@mangui
Copy link
Member

mangui commented Apr 8, 2016

having such fluctuations in fragment duration is a bit weird ?
anyway, it would make more sense to use average or min fragment duration to refresh live playlists.
PR welcome

gjanblaszczyk added a commit to gjanblaszczyk/hls.js that referenced this issue Apr 8, 2016
gjanblaszczyk added a commit to gjanblaszczyk/hls.js that referenced this issue Apr 9, 2016
@gjanblaszczyk
Copy link
Contributor

I added PR using average fragment duration. I hope that is enough for your case @shaharmor

gjanblaszczyk added a commit to gjanblaszczyk/hls.js that referenced this issue Apr 12, 2016
gjanblaszczyk added a commit to gjanblaszczyk/hls.js that referenced this issue Apr 14, 2016
mangui added a commit that referenced this issue Apr 15, 2016
gjanblaszczyk added a commit to gjanblaszczyk/hls.js that referenced this issue Apr 20, 2016
@capagrisdesu
Copy link
Contributor

My understanding of hls is that there is no master playlist (manifest) refetching/refreshing at all within hls.js unless loadSource is being called multiple times. Only media playlists/levels are being refreshed within the logic of the library. Maybe is just a simple naming convention misunderstanding with the title, since the library only uses manifest to refer to the Master playlist. Am I correct?

@stale
Copy link

stale bot commented Jun 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Wontfix label Jun 16, 2018
@stale stale bot closed this as completed Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants