Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer hole inside the HLS stream #363

Closed
gjanblaszczyk opened this issue Apr 8, 2016 · 2 comments
Closed

Buffer hole inside the HLS stream #363

gjanblaszczyk opened this issue Apr 8, 2016 · 2 comments
Labels
Bug

Comments

@gjanblaszczyk
Copy link
Contributor

Hi,
I have question about this HLS stream: http://dailymotion.github.io/hls.js/demo/?src=http%3A%2F%2Flevel3cdn.screen9.com%2FM%2FV%2F0%2FM%2F0Mp8FbLXAlfWozy_YsDXhA_480p_hls%2Fplaylist.m3u8%3Ftoken%3D063d9add3b68c54f6b39f&enableStreaming=true&autoRecoverError=true&enableWorker=true&levelCapping=-1&defaultAudioCodec=undefined

It looks like this steam has a buffer hole around 5 second. On the Firefox the steam is playing without and stuttering but on Chrome the stuttering is visible. Do you think this can be fix inside hls.js lib or should be fix on the backend side?

Cheers,
GregB
@gjanblaszczyk gjanblaszczyk mentioned this issue Apr 12, 2016
Closed
mangui referenced this issue Apr 13, 2016
@mangui
mp4-remuxer: fix PTS/DTS adjustement of first audio/video samples on …
1494a92 
…first and non contiguous fragment

in case of first/non contiguous fragment, only adjust PTS/DTS if there is a huge (more than 10s) unexpected delta between expected and parsed timestamp
=> respect A/V sync delay as advertised in the MPEG2-TS
=> fix buffer hole that might happen on subsequent contiguous fragment

related to https://github.com/dailymotion/hls.js/issues/363
related to https://github.com/dailymotion/hls.js/issues/351
mangui referenced this issue Apr 13, 2016
@mangui
update dist
35c1c04 
related to https://github.com/dailymotion/hls.js/issues/363
related to https://github.com/dailymotion/hls.js/issues/351
@mangui mangui added the Bug label Apr 13, 2016
@mangui
Copy link
Member

mangui commented Apr 13, 2016

Hi @gjanblaszczyk
plz recheck http://dailymotion.github.io/hls.js/demo/?src=http%3A%2F%2Flevel3cdn.screen9.com%2FM%2FV%2F0%2FM%2F0Mp8FbLXAlfWozy_YsDXhA_480p_hls%2Fplaylist.m3u8%3Ftoken%3D063d9add3b68c54f6b39f&enableStreaming=true&autoRecoverError=true&enableWorker=true&levelCapping=-1&defaultAudioCodec=undefined
it should be fixed now

@gjanblaszczyk
Copy link
Contributor Author

Thanks @mangui now it works fine

mangui added a commit that referenced this issue Apr 14, 2016
@mangui
mp4-remuxer: fix PTS/DTS adjustement of first audio/video samples on …
a1e45d7 
…first and non contiguous fragment

in case of first/non contiguous fragment, only adjust PTS/DTS if there is a huge (more than 10s) unexpected delta between expected and parsed timestamp
=> respect A/V sync delay as advertised in the MPEG2-TS
=> fix buffer hole that might happen on subsequent contiguous fragment

related to #363
related to #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mangui @gjanblaszczyk