-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delta playlist support #3644
Comments
Hi @gramk,
Please fill out the Bug Report Template as part of your issue, making sure to include:
I'll need the test stream you are using along with the expected and actual result. The latest release/head has support for delta playlists using the LL-HLS playlist samples provided by Apple (here's an example 🔊👂Cover your ears/mute first!). If you can reproduce the issues with their stream and describe how, or give me your stream and steps to repro I can investigate further.
Then please also consider contributing to the project by debugging the issue, and suggesting fixes via PRs. Just pop over from the Network tab to the Sources tab. The LL-HLS project is covered here https://github.com/video-dev/hls.js/projects/7 and includes links to the changes for these features (#3060). This is where SERVER-CONTROL is parsed if you're interested: |
Thanks @robwalch. Here is the information you requested: What version of Hls.js are you using?v1.0.0-rc.3.0.canary.6981 What browser and OS are you using?Chrome 89.0.4389.90 Test stream:Checklist
Steps to reproduce
Expected behavior
Actual behavior
Console output
|
Hi @ghouet, Currently hls.js only supports delta updates with streams that also support block reload; The delta update URL parameter is only added to playlist requests after checking |
I put up a PR that will go into the next release candidate. You can try it out with the sample stream at: |
Thanks so much Rob! Looks like it was a quick fix. |
@robwalch @ghouet Can you please help me understand how/where the _hls_skip flag gets added from? When I try inserting the same HLS URL at the following link, I do see the flag getting added: https://deploy-preview-3670--hls-js-dev.netlify.app/demo/?src=https%3A%2F%2Fdai.google.com%2Flinear%2Fhls%2Fevent%2FyWaDO8GzQiKuCOcLYGGFUQ%2Fmaster.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOnRydWUsInN0b3BPblN0YWxsIjpmYWxzZSwiZHVtcGZNUDQiOmZhbHNlLCJsZXZlbENhcHBpbmciOi0xLCJsaW1pdE1ldHJpY3MiOi0xfQ== However, when I try using the URL with the demo page, it does not seem to add the flag: https://hlsjs.video-dev.org/demo/ Additional details: I tried using the HLS script from https://cdn.jsdelivr.net/npm/hls.js@1 - that too does not seem to add the flag |
Hi @deepak-bomotix, This issue is closed. Please File a New Question or Bug Report. |
Is your feature request related to a problem? Please describe.
Part of the Apple low latency HLS specifications describes the Delta playlist feature. Each feature of LL-HLS can be used independently and we at Google are very interested in the client and server savings that the delta playlist updates feature can offer.
Describe the solution you'd like
We'd like that feature to be implemented as per apple specification. Testing head as of 2021 March 17th does not show the _HLS_skip=YES query parameter added to the media playlist request when #EXT-X-SERVER-CONTROL:CAN-SKIP-UNTIL={n} is advertised:
Describe alternatives you've considered
n/a
Additional context
See apple presentation about that specific feature:
https://developer.apple.com/videos/play/wwdc2020/10230/#:~:text=So%20Playlist%20Delta%20Updates%20are,version%20that's%20on%20the%20server.
The text was updated successfully, but these errors were encountered: